add pub functionality for zaino

idky137 commented 1 month ago

Motivation

For Zaino to use Zebra as its backed it requires access to primitives held in Zebra-Chain and Zebra-RPC.

This PR will complete Task 1 of https://github.com/zingolabs/zaino/issues/50

Solution

-Several structs in zebra-rpc were made pub and getter / setter functionality was added. -From impl was added to ['ConsensusBranchId'] in zebra-chain.

Tests

The most complex functionality added is simple getter / setter impls, I believe that adding new tests for this would be inefficient / redundant.

Follow-up Work

Due to patched libraries in Zebra:main causing issues in Zaino these changes were made atop v1.9.0, once the patches are removed we will update the zebra version to 2.0.0, there is a chance that additional changes will be required for changes in zebra v2.0.0.

PR Author's Checklist

[ ] The PR name will make sense to users.
[ ] The PR provides a CHANGELOG summary.
[ ] The solution is tested.
[ ] The documentation is up to date.
[ ] The PR has a priority label.

PR Reviewer's Checklist

[ ] The PR Author's checklist is complete.
[ ] The PR resolves the issue.

idky137 commented 1 month ago

I'm not sure whether these changes require a CHANGELOG entry?

idky137 commented 1 month ago

Please let me know if there is anything I can do to help remove the 'Do-Not-Merge' Tag..

mpguerra commented 4 weeks ago

Please let me know if there is anything I can do to help remove the 'Do-Not-Merge' Tag..

It was just while we were prepping the release. We should be good to merge now that's out :)

oxarbitrage commented 2 weeks ago

Hi @idky137 can you update your branch with the last main ? We just merged some fixes to the external contributor workflow and we want to check if it is working.

ZcashFoundation / zebra