ZcashFoundation / zebra

Zcash - Financial Privacy in Rust 🦓
https://zfnd.org/zebra/
Apache License 2.0
412 stars 106 forks source link

fix(ci): Avoid caching state in `lwd-update-sync` job #9029

Closed arya2 closed 6 days ago

arya2 commented 6 days ago

Motivation

This test is failing in CI since https://github.com/ZcashFoundation/zebra/pull/9004, it's not clear why it was passing before then as the expected log was missing before #9004 as well.

The test documentation says it's meant to be run with an empty Zebra and lightwalletd test (and it is consistent with the test code). The test should not be producing an updated cache state, it should never be saved to a cached disk for other tests to use.

Depends-On: #9026.

Solution

Sets the needs_zebra_state, needs_lwd_state, save_to_disk, and force_save_to_disk Github action inputs as false for the lightwalletd-update-sync job.

Related changes:

Tests

The test should pass in CI for this PR.

PR Author's Checklist

PR Reviewer's Checklist