search

ZeBobo5 / Vlc.DotNet

.NET control that hosts the audio/video capabilities of the VLC libraries
MIT License
947 stars 415 forks source link

Changing Hue Via Video.Adjustments.Hue #215

Open BorisBrock opened 7 years ago

BorisBrock commented 7 years ago

Changing a video's hue via Video.Adjustments.Hue seems to have no effect. No matter which value I use, the video does not change at all.

All other settings in Video.Adjustments seem to work fine though:

If I change any of these I can see an immediate effect. Is this a bug? Which value range does the hue property support?

BorisBrock commented 7 years ago

I just found the problem while browsing through the VlcDotNet sources:

In the AdjustsManagement you are treating the hue as a float. That includes setting it via "libvlc_video_set_adjust_float". But actually it is an integer (0-360) that needs to be set via "libvlc_video_set_adjust_integer".

A quick test with using "int" and "libvlc_video_set_adjust_integer" worked perfectly on my machine. -> can you fix that?

jeremyVignelles commented 6 years ago

Hi, Where did you find the info that says it's an integer in range 0-360 ? I saw this line that tends to say the opposite :

https://github.com/videolan/vlc/blob/ef7c26f5a76c1239b17dffb51879ee61753cfce0/lib/video.c#L1048

And this line tends to say it's in the range -180/+180 : https://github.com/videolan/vlc/blob/d5c86c91a2700618d97916103e854a46c1bd5e32/modules/video_filter/adjust.c#L68

EDIT : changing the type to int changed nothing for me, could you please share a code example?