ZeBobo5 / Vlc.DotNet

.NET control that hosts the audio/video capabilities of the VLC libraries
MIT License
947 stars 416 forks source link

Check memory leaks on char* returns from libvlc #387

Open jeremyVignelles opened 6 years ago

jeremyVignelles commented 6 years ago

Here is an example : https://github.com/videolan/vlc/blob/7d141bf19fa57c79c1deb4617441b5966d8762fc/include/vlc/libvlc_media_player.h#L1156 Do we free that correctly?

mfkl commented 5 years ago

AFAIK, for libvlc 3, there are 4 instances of such char* pointers to explicitly free (see https://github.com/videolan/libvlcsharp/search?q=LibVLCFree&unscoped_q=LibVLCFree)

jeremyVignelles commented 5 years ago

Thanks for investigating. Based on your libvlcFree: true, there are :

These are not free'd properly and need to be worked on to avoid memory leak.