ZeChrales / PogoAssets

Unity assets
423 stars 154 forks source link

Female Fragment Hat Raichu Sprites Missing #13

Closed PaulGolting closed 5 years ago

PaulGolting commented 6 years ago

Hello! This is my first time ever submitting an "issue" on GitHub. The last ZIP that I downloaded of all the PoGo assets just a few days ago does not have these Sprites: -Female Fragment Hat Raichu -Shiny Female Fragment Hat Raichu

Also, I noticed a bunch of duplicate Alolan Raichu Sprites, both normal & Shiny. Attached are some screenshots of the files in the ZIP.

Anyways, just thought I would mention it. Not sure what happened or if maybe I'm totally just missing it. Thanks for all your work with this!

screen shot 2018-10-11 at 3 32 27 pm

screen shot 2018-10-11 at 3 33 09 pm
PaulGolting commented 6 years ago

@ZeChrales - Hello! First of all, thank you for all your hard work providing such a wonderful resource to the PoGo community.

Now, I've been seeing issues being replied to by multiple people and issues being closed but I haven't heard anything about this issue. I'm not sure what Discord server you are on, so I figured I would just message here. Not sure if this issue with the Fragment Sprites is valid or if it's just me.

Anyways, thanks for your time!

rmkane commented 5 years ago

The female sprite was never committed.

PaulGolting commented 5 years ago

The female sprite was never committed.

Hello @ryankane ! Thanks for commenting. What exactly do you mean by that?

bdaubry commented 5 years ago

@ryankane @PaulGolting it's not that it was never committed, it doesn't exist in network traffic. Niantic didn't put it on the server, basically. Check out this imgur album. If you notice, both of the fragment hat sprites show as male. Yet, the one with 1911CP is definitely female. They don't have the right sprite on the server, so they both show as male in your storage. If you look at the witch hat Raichu, you can see that the correct sprites were added.

A similar issue happens with shiny Male Luxio. The sprite shows the non-shiny version, even though it is shiny. I can't show any screenshots of it, as I don't have one, but it has been posted about on TheSilphRoad. However, this issue differs because there actually is a sprite uploaded with the correct filename, but it has the non-shiny form. Basically, there are no differences between the regular and shiny sprite files.

For the Alolan Raichu, the naming scheme will give a bit of a hint. The filenames end with 3 separate numbers. In this case, 026, the Pokedex number; 00, 01, or 61, the gender/Alolan reference number; and 00 through 06, the form reference number. When Alolans were added, the gender numbers were changed with a leading 6 instead of a 0. However, since no Alolan Pokemon show gender differences, the Alolan "form" is always 61. For some reason on Niantics end, they always add a new Alolan form for every hat form that comes out. However, since they aren't available with hats, they are all the same sprite.

Anyway, long story short, all the icon filenames follow the same format. pokemon_icon_pokedexNumber[_gender][_form].png, where anything in [] is 'if applicable'

bdaubry commented 5 years ago

Here's a link to the issue with a screenshot of the Luxio shiny sprite being wrong

PaulGolting commented 5 years ago

@bdaubry - Thank you so much for your reply! I was thinking that was the case with the Female Frag Hat Sprites - that Niantic messed up with the Sprite files on their servers. However, I wasn't sure if that was what actually happened. With you mentioning it and proving it with the screenshots, that is all that I needed!

As for the Alolan Raichu, I appreciate you providing that explanation - it makes total sense! However, is that your speculation about what happened, or is that something you know for sure is what happened? Just wondering. Either way, it seems like that is what happened.

Again, thanks for your detailed comment with all your info and help!

bdaubry commented 5 years ago

@PaulGolting ZeChrales only adds stuff here that he is able to pull from network traffic, so there is a un-hatted Alolan Raichu sprite and image file for every hatted Raichu variant. Why Niantic does it that way, I can't honestly say. Maybe they intend to add Alolan Raichu with a hat in the future, and all it would take would be updating the sprite assets, or maybe it's just an unintended consequence of the way they add hatted forms on the back end.

rmkane commented 5 years ago

Male sprites exist:

Female sprites do not exist:

I went ahead and took the male sprites and spliced in the female tails from the Summer model. I noticed that all the female sprites are slightly smaller than the male sprites (except for the Summer model). By the way, the Summer female sprites appear a bit blurry, like they were up-scaled.

pokemon_icon_026_01_06 pokemon_icon_026_01_06_shiny

PaulGolting commented 5 years ago

@ryankane - Oh cool! Thanks for the Sprites and for the info you provided!

rmkane commented 5 years ago

This issue should now be marked CLOSED, since the sprites were updated and added.

See commit "raichu update" f0b495a02c8673d845c3850dc1caf3e5c0b29812

PaulGolting commented 5 years ago

@ryankane - Awesome! I just got the new files! Glad that it was fixed! :)