ZeDespo / Ultimate-Ganondorf

Ganondorf is my favorite character, and Ultimate S did a lot of really amazing things with him. Port Ganondorf as a downloadable mod.
0 stars 1 forks source link

Up special decoupling #5

Closed ZeDespo closed 1 month ago

ZeDespo commented 1 month ago

Teleport had been tightly coupled with float logic and neutral air, which added multiple layers to an otherwise simple implementation with status scripts. This PR...

  1. Decouples Up-Special logic away from float.rs and neutral_air.rs, making the code for each move more isolated and following SOLID principles.
  2. Moved effects / sounds to acmd file.
  3. Moved hitboxes for the teleport away from neutral air and into the acmd file.
  4. If using teleport from air to ground, it automatically cancels and ganondorf can act immediately.