search

ZeLonewolf / openstreetmap-americana

A quintessentially American map style
https://zelonewolf.github.io/openstreetmap-americana
Creative Commons Zero v1.0 Universal
173 stars 56 forks source link

Group GLCT definitions together #1074

Closed ZeLonewolf closed 1 month ago

ZeLonewolf commented 1 month ago

This is a minor refactor to put all the GLCT (Great Lakes Circle Tour) shield definition code together in the same place in shield_defs.json. They were thousands of lines apart which made it confusing to understand what was going on.

image

claysmalley commented 1 month ago

All of the overrideByRef, overrideByName and refsByName cases are at the end of the file. Either we should keep all of them together, or get rid of this section and put all of the special cases inline.

ZeLonewolf commented 1 month ago

Ah, I see. It wasn't obvious to me that's what was going on here. At the least, we ought to group all parts of a shield definition together. For example, in the Nova Scotia section we find:

  shields["CA:NS:S"] = {
    notext: true,
  };

Totally unclear that there's additional definition at the end of the file. I think the original notion was that we wanted to tightly limit the number of special cases and that's why we segregated them. :thinking:

quincylvania commented 1 month ago

I could see the number of "special cases" growing to the point where they're not so special. I think it makes more sense just to organize everything consistently.

ZeLonewolf commented 1 month ago

Superceded by #1081