ZeNyfh / gigavibe-java-edition

Music + Media bot made in java using JDA and Lavaplayer.
GNU General Public License v3.0
8 stars 3 forks source link

Add audio filter support (speed, pitch, etc) #131

Closed ZeNyfh closed 4 months ago

ZeNyfh commented 7 months ago

There is issue #47 however that was very broad and included more than just audio filters, making this its own issue.

These 2 features are a priority, however this is not an extensive list, more features may come from this.

ZeNyfh commented 7 months ago

set to priority high as this has been requested by users.

ZeNyfh commented 5 months ago

I am working on this (while at college on a vpn) and I have it working in a test environment, all I need to do is move the logic into commands and this will finally be a feature.

9382 commented 5 months ago

bugs to figure out, keeping this open until resolved (To be specific, Zenyfh has some weird persistance issues with vibrato beyond restarts and mine just doesnt work at all)

9382 commented 5 months ago

Update: It seems the filters don't like working together, and one of the filters (which to be specific is random) will not work while the other will. E.g. pitch doesnt work but vibrato does; restart instance; pitch works and vibrato doesn't. Very bizarre behaviour, will need to figure this out

9382 commented 4 months ago

Both filters now correctly apply. Beyond some cleanup of how we want to access filters (done) and some arg filtering for the user-facing commands, this is pretty much complete

ZeNyfh commented 4 months ago

fixed in https://github.com/ZeNyfh/gigavibe-java-edition/commit/6b8434a6fda132bfd235f43b2f1a1c740498e612