ZeNyfh / gigavibe-java-edition

Music + Media bot made in java using JDA and Lavaplayer.
GNU General Public License v3.0
8 stars 3 forks source link

Potential better handling method for slash commands #143

Closed 9382 closed 4 months ago

9382 commented 5 months ago

Currently, looking at UpdateSlashCommands and other stuff, we call updateCommands on every guild specifically rather than doing it under the bot in general. This feels like excessive extra leg work and I'm not sure what this entails for the first time a bot joins a new server. We should really think about swapping to doing it under the bot instead (its just as simple and probably more efficient, plus it would force apply every reboot) @ZeNyfh Is there any reason this is done specifically under every guild instead of as a bot in general?

ZeNyfh commented 5 months ago

Implement this and lets see what happens. Keep in mind that both systems will apply therefore "updateslash" may have to be temporarily updated to remove all existing commands in every guild.

9382 commented 5 months ago

Implemented. Close this issue once you update the bot and run /removeslash

ZeNyfh commented 4 months ago

I have done the deed.