Fixes #159 - Githubissues

ZeNyfh / gigavibe-java-edition

Music + Media bot made in java using JDA and Lavaplayer.

GNU General Public License v3.0

8 stars 3 forks source link

Fixes #159 #166

Open WolfNT90 opened 2 months ago

WolfNT90 commented 2 months ago

Okay then LOL, I'm gonna commit my progress in a PR so that bug-tracking and collaboration actually works and happens.

Goals of this PR

[x] Merge or further define AutoplayHelper as a class/utility
[x] Defer to AutoplayHelper for autoplay
[x] Correct a visual encoding bug mentioned in #159 regarding '+' showing up, along with /most/ instances of wrong author formatting (in youtube's case, "channel - artist - title" would show up)
[x] Correct an issue where Autoplay would try to queue the same song
[x] Sometimes, Autoplay would erroneously report that "No similar tracks" were found (testing)
[x] Address undesirable behavior where Autoplay always queues the first result from LastFM
[ ] Address an issue where Autoplay can queue the same track
[ ] Improve song title parsing and lookup logic
[ ] Correct user-facing embed issues
[ ] Housekeeping (make sure all #doAutoplay calls are in the correct places to be)

WolfNT90 commented 1 month ago

I'll be doing testing and refactoring involving the other parts of autoplay later today.

WolfNT90 commented 1 month ago

As of b169e7a...

Merge or further define AutoplayHelper as a class/utility & Defer to AutoplayHelper for autoplay are going well. I plan to rename AutoplayHelper to simply Autoplay, as it handles more and more the logic behind autoplaying music.

I've yet to correct an issue where Autoplay would try to queue the same song, but the erroneous report of "No similar tracks" didn't happen with the songs tested.

Autoplay now uses random to avoid always queuing the first result from LastFM. I've yet to address Autoplay queuing the same track.

I have comments and a it's somewhat of a mess everywhere. This PR is based off latest main with usually just a 12 hour difference, so it should be good to checkout and test/run, but I wouldn't consider it ready for live use at all yet. There are a few visual issues with autoplay and embeds. More on that over the next commits.

ZeNyfh commented 1 month ago

Sometimes, Autoplay would erroneously report that "No similar tracks" were found (testing)

I will omit (mark as complete) this as it shouldn't be an issue with the changes that I will make to autoplay that we discussed in dms around a week ago. (maintaining fixed queue length of 20)

ZeNyfh commented 1 month ago

giving an approval of the current changes, there are no issues that stand out.