search

ZeStream / zestream-server

an open-sourced alternative to cloudinary [video streaming done ✅, image/audio under dev 🔨 ]
GNU General Public License v3.0
203 stars 41 forks source link

Replaced fatal logging #56

Closed akshat2602 closed 1 year ago

akshat2602 commented 1 year ago

Replaced fatal logging with normal log.Println and returning the error to the controller for further handling. Haven't added in any log level as the base logger in go has no option for that. Fixes #40

akshat2602 commented 1 year ago

While setting up the dev environment I also noticed that some packages are missing from the go.mod file. Specifically the cloud.google.com/go/storage package and github.com/Azure/azure-storage-blob-go package. I think go.mod might've not been committed when these packages were added in for some functionality. Can you please check once? @uzaxirr

uzaxirr commented 1 year ago

Hey Thanks for the PR Please checkout this comment https://github.com/ZeStream/zestream-server/pull/44#discussion_r1060819382

And let me know if you can do the changes in this PR itself?

Whereas the go.mod file issue is concerned can u create a new issue for it

akshat2602 commented 1 year ago

And let me know if you can do the changes in this PR itself?

Yeah, sure will make the changes.

Whereas the go.mod file issue is concerned can u create a new issue for it

Yes, will do that and will also issue a PR for that.