search

ZebraDevs / DataWedge-Ionic-Demo

Demo Ionic application using Datawedge on Zebra mobile devices
Other
44 stars 21 forks source link

npm install fails #11

Closed invot closed 4 years ago

invot commented 4 years ago

This project no longer seems to build. Also, will you be adding support for ionic v4 anytime soon?

darryncampbell commented 4 years ago

Hi, what build issues are you seeing? I tried this morning and resolved the few issues I saw in a branch: https://github.com/Zebra/ZebraIonicDemo/tree/20191205_build_issues

Regarding Ionic v4, I have set myself a reminder to look at that between Christmas & new year when most other people are out the office

invot commented 4 years ago

Wow. Thank you for such a quick response! I'll dabble with your new branch and let you know if anything weird happens.

I'm curious to see what kind of work is involved in migrating from version 3 to 4. If it's just different namespaces or whatnot, I might give it a try and submit a pull request.

darryncampbell commented 4 years ago

Regarding Ionic v4, please see this comment: https://github.com/Zebra/ZebraIonicDemo/commit/c0338cfa05cb45b97bb294578f71cbe219fd0ead#diff-04c6e90faac2675aa89e2176d2eec7d8 . I believe this issue can now be closed?

invot commented 4 years ago

I think this issue can be closed, yes.