search

ZebraDevs / fetch_gazebo

Gazebo simulator for Fetch
101 stars 89 forks source link

Fixes noetic compatibility #113

Closed rickstaa closed 3 years ago

rickstaa commented 3 years ago

This commit fixes a xacro.py not found bug that was thrown when trying out the package on ROS noetic. For more information see https://wiki.ros.org/noetic/Migration. I am not sure if we can directly merge these changes on the gazebo9 branch or that we need to use a new gazebo9-noetic branch.

erelson commented 3 years ago

Hi @rickstaa thanks for the fix PR! It looks like I followed the migration guide already a while ago (I have no memory of this though 😅 ) and there's a gazebo11 branch on this repo with that same change: https://github.com/fetchrobotics/fetch_gazebo/tree/gazebo11 and https://github.com/fetchrobotics/fetch_gazebo/commit/5e50ab2dad72ff8f8b74301d01167179f8a04fa5

Can you let me know if that branch works for you? Or are you actually using gazebo9 + noetic? I have not actually spun up gazebo in 20.04/noetic myself...

If that branch works for you, I think we can close this PR?

rickstaa commented 3 years ago

@erelson Ah your right gazebo11 is the recommended version for noetic. My submodule was not updated 😅 . Sorry to have bothered you.