search

ZebraDevs / fetch_robots

Bringup for fetch & freight
12 stars 52 forks source link

REP-146 changes #54

Open moriarty opened 5 years ago

moriarty commented 5 years ago

We merged a PR #22 however it looks like things changed from robot/name and robot/type to robot_name and robot_type

https://github.com/ros-infrastructure/rep/pull/104#issuecomment-452182600

@moriarty fetchrobotics/fetch_robots#22 uses robot/name and robot/type but this REP uses robot_name and robot_type. Can we update fetchrobotics/fetch_robots#22 ? or change this REP? c.f. https://github.com/ros-infrastructure/rep/pull/104/files/7410b7a91de3f2460a9065cf93a31cd45330f9fc#r187465995

moriarty commented 4 years ago

FYI @erelson & @cjds this is a simple task