add velocity-factor in calibrate_robot

ZebraDevs / fetch_ros

Open ROS Components for Robots from Fetch Robotics

177 stars 151 forks source link

add velocity-factor in calibrate_robot #133

Closed knorth55 closed 4 years ago

knorth55 commented 4 years ago

add --velocity-factor to slow down calibration motions

erelson commented 4 years ago

Hi @knorth55 , thanks for the PR! This is an easy one for me to review, so I'm happy to merge it. I tacked on a commit with a couple slight modifications. Do those look reasonable to you?

I know you have a few other PRs open. Due to limited time to test (though they're small and clear fixes generally), my current intention is to review and test them all in one go on hardware at the point where we decide to do our next research release. Hope that sounds reasonable, as well!

knorth55 commented 4 years ago

@erelson Thank you for your reply. It means that these PRs will be merged just before the next research release? It would be fine for me.