search

ZebraDevs / fetch_ros

Open ROS Components for Robots from Fetch Robotics
176 stars 148 forks source link

[fetch_navigation][melodic] add launch_map_server argument in fetch_nav.launch #147

Closed knorth55 closed 3 years ago

knorth55 commented 4 years ago

melodic version of #146

add launch_map_server argument in fetch_nav.launch we use this commit to use other map server, such as multi_map_server.

we don't have fetch with melodic, so we haven't tested on a real robot.

cc. @708yamaguchi

erelson commented 3 years ago

Hi @knorth55, Thanks for the PR! My inclination is to leave the default for the added param as False, instead of True. This makes it simple to launch the fetch_navigation with defaults, with or without a map server running. For example, we do this when building a map: http://docs.fetchrobotics.com/navigation.html

Does that quick change sound reasonable on your end?

knorth55 commented 3 years ago

I set launch_map_server as true to keep default behavior of the launch. But if you want, i can change it to false.

erelson commented 3 years ago

I apparently can't read, you are correct. 😅