ZebraDevs / fetch_ros

Open ROS Components for Robots from Fetch Robotics
177 stars 151 forks source link

[feature] Noetic support? #155

Open pabloinigoblasco opened 3 years ago

pabloinigoblasco commented 3 years ago

Hello. Is this repo planned to be supported in noetic?

We are using it in our examples in the smacc project and we wanted to move to noetic. We tried to add this project as git submodule and it partially works, but not totally.

https://www.youtube.com/watch?v=FYeNzukdIz4

At the current moment what I did as a workaround is to add the repo as a submodule (forking with some minor changes to at least pass the compilation stage). However it does not work in runtime properly.

erelson commented 3 years ago

Hi @pabloinigoblasco

Yep, we essentially have noetic support but haven't released it yet; still need to do more testing on my part, and have been busy the past month or so. You can check out a few open PRs on this repo and the fetch_robots repo, in particular, with what changes we've got. Note that for noetic, the branch names we're using are "ros1" instead of "noetic_devel".

I think the equivalent to your linked gist is here: https://github.com/fetchrobotics/fetch_ros/pull/153/files#diff-e121feaf915d1716869198c422dfb66a86b6dfe56f7ebfdb8597cc90b78a39f2R17

One spot my testing ability that is a bit weak is with Gazebo. Is that part of what your team are experimenting with?

I also haven't personally played with git submodules myself in the past, but feel free to let me know what's not working in that regards.

pabloinigoblasco commented 3 years ago

I will try that branch you say.

I will now retry everything but starting from the ros1 branch.

Nonetheless I have to say that some things in that ros1 branch looks like won't work on my environment. For example, in my system in ubuntu 20.04 looks like the default opencv version is 4.2 instead 3.2. I think, that my environment is correct (ref)

I see in your ros1 branch you still reference 3.2 so maybe that approach you have in that branch is incorrect for noetic ubuntu 20.04.

erelson commented 3 years ago

I see in your ros1 branch you still reference 3.2 so maybe that approach you have in that branch is incorrect for noetic ubuntu 20.04.

You might be reading the diffs incorrectly? My link above indicates version is 4.2, same as you're seeing. Or alternately you're using the "current" ros1 branch, where as my link is to changes that are still in PR. The erelson/noetic_tweaks branch is currently the latest. Let me know how it goes, though!

(To be clear, I haven't tried the Gazebo demos, etc. in noetic myself yet)

pabloinigoblasco commented 3 years ago

Hello. Thanks for your help. We already have our three fetch demos working based on your erleson/noetic_tweeks pull request. We used the fetch_melodic gazebo version and looks to be working correctly. We have our own gazebo scenarios so we did not tested the gazebo package intensively.

In our examples we faced three minor issues that may not be related with your work and repositories.

image

erelson commented 3 years ago

Just a quick note: there are ros-testing debians for everything needed for a ros noetic robot now. I need to test the USB version of the customized 20.04 OS installer still...