search

ZebraDevs / robot_controllers

Robot control infrastructure
92 stars 79 forks source link

[GCC][Warnings] SYSTEM includes and catch ref #36

Closed moriarty closed 4 years ago

moriarty commented 6 years ago

This is an attempt to fix (silence) the buildbot failures from -Werror

@rctoris I didn't see the build error which the build farm complains about locally- but this would ignore warnings from system headers which we depend on.

moriarty commented 6 years ago

locally the only warming I get with this package is

/home/amoriarty/melodic-unique/src/robot_controllers/robot_controllers_interface/src/controller_loader.cpp:55:44: warning: catching polymorphic type ‘class pluginlib::LibraryLoadException’ by value [-Wcatch-value=]
     catch (pluginlib::LibraryLoadException e)
                                            ^

which is why I changed that line

moriarty commented 6 years ago

@rctoris I don't have access rights on this repo.

erelson commented 6 years ago

Fixed that for you