search

ZebraDevs / robot_controllers

Robot control infrastructure
92 stars 79 forks source link

Add time_from_start information to feedback topic #37

Closed 708yamaguchi closed 6 years ago

708yamaguchi commented 6 years ago

When I used fetch with follow joint trajectory, I found /*_controller/follow_joint_trajectory/feedback topic do not have time_from_start information, so I added time_from_start to this topic.

CC @pazeshun, @k-okada

708yamaguchi commented 6 years ago

@mikeferguson Thank you very much for your advice. I use ros::Time instance instead of control_msgs::FollowJointTrajectoryGoal instance.

708yamaguchi commented 6 years ago

@mikeferguson I think this pull request works well. If there is no problem, could you please merge this?

mikeferguson commented 6 years ago

I don’t have merge rights, since I’m no longer with Fetch Robotics.

708yamaguchi commented 6 years ago

I did not know that. Thank you very much for your cooperation in this pull request.

rctoris commented 6 years ago

@708yamaguchi can we get an equivalent PR into the melodic branch as well?

708yamaguchi commented 6 years ago

@moriarty @rctoris

I created an equivalent Pull Request into the melodic branch (https://github.com/fetchrobotics/robot_controllers/pull/38).