build fixes for noetic - Githubissues

ZebraDevs / robot_controllers

Robot control infrastructure

92 stars 79 forks source link

build fixes for noetic #44

Closed mikeferguson closed 4 years ago

mikeferguson commented 4 years ago

This should support both melodic and noetic on same branch:

orocos_kdl is now a system dependency so the rosdep key has changed.
package format 3 is required to handle conditional on rosdistro
old build hackery is no longer needed.
cmake minimum version is updated per migration guide (http://wiki.ros.org/noetic/Migration) supports as far back as Kinetic.

erelson commented 4 years ago

Thanks @mikeferguson! I wasn't previously aware of the possibility to use a branch for both melodic and noetic, but makes sense in retrospect (with the little bit of bloom experience I have).

It seems like for almost everything (i.e. packages anything w/o python that's not compatible with both 2/3), we could just operate with noetic and melodic both being released from the melodic-devel branch. That would save a lot of potential backports; any reasons not to do this?

mikeferguson commented 4 years ago

Absolutely no reason to create separate branches. I'd also suggest at some point renaming it to "ros1" when you start to have a "ros2" branch (which I'll probably be bugging you about in a few weeks - working on a port).

erelson commented 4 years ago

I'm fine with going ahead and merging this, @mikeferguson