Switch class_list_macros import from h to hpp

ZebraDevs / robot_controllers

Robot control infrastructure

92 stars 79 forks source link

Switch class_list_macros import from h to hpp #58

Closed cjds closed 4 years ago

cjds commented 4 years ago

Found this while trying to import class_loader into bazel land. I'm not sure why this hasn't bitten us before. In the official class_loader repository they recommend importing class_loader.hpp instead of class_loader.h

https://github.com/ros/class_loader/blob/melodic-devel/include/class_loader/class_loader.h#L40

I found that I could not compile with class_loader.h and would hit that deprecation notice. However, when we catkin build we do not hit that.

cjds commented 4 years ago

@mikeferguson @erelson looks like we're still using some kind of bionic agent to test PRs to melodic. Should we switch/add a focal one as well if we want to test against noetic?

mikeferguson commented 4 years ago

We can do an initial release into noetic and add CI - but not until #44 is merged

cjds commented 4 years ago

Good point about kinetic. Maybe we should split a kinetic branch off even though we've never supported it officially @erelson thoughts?

erelson commented 4 years ago

Or should we make a ros1 branch and put this PR into that?

cjds commented 4 years ago

Could do that as well. Make that the default branch and test against melodic and noetic for it?

erelson commented 4 years ago

@cjds I have made a ros1 branch for this. Want to re-point this PR at that?

cjds commented 4 years ago

Yes!