Revert "Added gyro interface to robot controllers (#43)"

ZebraDevs / robot_controllers

Robot control infrastructure

92 stars 79 forks source link

Revert "Added gyro interface to robot controllers (#43)" #68

Closed knorth55 closed 3 years ago

knorth55 commented 3 years ago

This reverts commit 6452011adb64f79f72a08e361be4282d31e1a71f. this solves the issue #67

mikeferguson commented 3 years ago

I think that fetch_drivers have not been rebuilt and re-released and this PR changed API & ABI - if you check out the 0.6.0 tag of this repo, it should work.

mikeferguson commented 3 years ago

@erelson Looking at this, we should branch noetic-devel and then merge this PR so that melodic-devel continues to work with the released drivers, but noetic has the newer interfaces included.

erelson commented 3 years ago

That's a great solution, thanks!

erelson commented 3 years ago

Gotta do a bit more than that so internal stuff doesn't risk any breakages, but will make it happen.

erelson commented 3 years ago

Should someone want a branch with this code still live, I duplicated it to https://github.com/fetchrobotics/robot_controllers/tree/melodic-devel-internal.