search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Investigate clang-format action for ideas on customisable docker base image #100

Open ZedThree opened 1 year ago

ZedThree commented 1 year ago

See https://github.com/jidicula/clang-format-action

Top-level action is a composite action and somehow controls the base image used for the docker image. This allows them to support lots of clang-format versions. Potentially could do something similar here to also allow running in parent image, without needing to do the faff with installing packages inside our action's container. Or it might not work at all.

eguiraud commented 8 months ago

Hi, there is another important use-case for this: the way clang-tidy-review currently works, it always runs on ubuntu 23.04, which sometimes has incompatible library versions w.r.t. the system where the compile_commands.json was generated.

In my case, the system where I run the build is (read: must be) Ubuntu 22.04, which ships Python 3.10, so clang-tidy inside the 23.04 docker image (which ships Python 3.11) can't find the Python.h header at the location indicated by the compile_commands.json.

ZedThree commented 7 months ago

I'd really really like to implement this, I just don't have time to investigate properly at the moment! If there's anyone reading this who's interested, please feel free to give it a crack!