ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

PR login name for `google-readability-todo` #102

Closed bwrsandman closed 8 months ago

bwrsandman commented 10 months ago

It would be useful if the PR author's username was used for the suggested fix of google-readability-todo. Currently it has unknown. image

Clang-tidy gets the name from the USER environment variable, the config parameter and the config files. This is how I would do it if it wasn't in a container. USER: ${{ github.event.pull_request.user.login }}

ZedThree commented 10 months ago

Should be possible to pass that in as an argument?

bwrsandman commented 10 months ago

Should be able to do this with the github api and setting the docker's env without needing an argument.

I don't see why we'd want an argument for this unless users prefer using something else than login