ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

Fix Recursive source clang-tidy #104

Closed bwrsandman closed 8 months ago

bwrsandman commented 8 months ago

There's an issue when trying to run clang-tidy without --checks and --config-file. This is the case when you want to use the .clang-tidy configs in a recursive per-directory way.

In #96, I added the ability to set both checks and config to empty strings which did this, however, switching to shell=False, means that empty strings still count as arguments.

This ends up with '' being sent to clang-tidy as an agument which clang-tidy interprets as a file name ($PWD + '' to check. It then emits and error that the current directory cannot be opened.

This PR makes sure that in this case, the '' argument is not set and prints a more useful message in that case.