ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

Fix line filter on for clang compiler on windows #108

Closed bwrsandman closed 8 months ago

bwrsandman commented 8 months ago

The line filters seem to be sensitive to the compiler used. When using MSVC, the line filter must use backslashes in the name. However, if the clang compiler is used on Windows, it must be forward.

The simplest solution to this issue is to use an extra entry of the line filter one with forward slashes and one without. This allows all compilers to be happy regardless of OS and without looking at compilation databases.