search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Support clang-tidy-13 #11

Closed vadi2 closed 2 years ago

vadi2 commented 3 years ago

It would great to have support for the latest version of clang-tidy :+1:

ghutchis commented 3 years ago

AFAICT clang-tidy-11 is already part of the focal universe: https://packages.ubuntu.com/focal-updates/clang-tidy-11

vadi2 commented 3 years ago

Sure, but I mean 12

ghutchis commented 3 years ago

I know - but clang-tidy-12 isn't yet available for focal, so AFAIK, it's not just a quick Dockerfile update.

ZedThree commented 3 years ago

I guess if LLVM 12 is available from a reputable PPA, that would work?

ghutchis commented 3 years ago

I'm not a Dockerfile expert.. Worth a try: https://packages.ubuntu.com/hirsute/clang-tidy-12

vadi2 commented 2 years ago

clang-tidy-13 is out now and adds some great checks such as https://clang.llvm.org/extra/clang-tidy/checks/readability-function-cognitive-complexity.html, would be great to make use of it in PRs - sometimes people contribute functions way too big.

umutoztunc commented 2 years ago

We should at least add clang-tidy-12 which is available for focal: https://packages.ubuntu.com/focal-updates/clang-tidy-12

ZedThree commented 2 years ago

I've added clang-tidy-12. I think it's important that the base image is something fairly standard, otherwise it could be painful to support most people's workflows. This means that supporting the latest clang-tidy as it's released is probably a no-go I'm afraid.

If someone knows how to make the base image be an argument from the Action, then PRs are very much welcome :)