search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

new release needed: posting from a split workflow fails with error #117

Closed BenWibking closed 7 months ago

BenWibking commented 8 months ago

Posting the review comments from a split workflow fails with the error:

Traceback (most recent call last):
Attempting to automatically download review artifacts
  File "/usr/local/bin/post", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.[12](https://github.com/quokka-astro/quokka/actions/runs/8300661163/job/22719069742#step:3:13)/site-packages/clang_tidy_review/post.py", line 80, in main
    metadata, review = download_artifacts(pull_request, int(args.workflow_id))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/clang_tidy_review/__init__.py", line 929, in download_artifacts
    "GET", artifact.archive_download_url, headers=pull.headers("json")
                                                  ^^^^^^^^^^^^
AttributeError: 'PullRequest' object has no attribute 'headers'

See https://github.com/quokka-astro/quokka/actions/runs/8300661163/job/22719069742

BenWibking commented 7 months ago

It looks like this was fixed in https://github.com/ZedThree/clang-tidy-review/pull/115, but there hasn't been a release yet that incorporates this fix. Can one of the project admins make a new release?

ZedThree commented 7 months ago

@BenWibking Apologies, missed that I hadn't made a new release, now available as v0.17.2