I'm sorry for not testing properly in https://github.com/ZedThree/clang-tidy-review/pull/115. The stuff still fails, because pygithub doesn't follow redirects and the artifact is a binary blob, not JSON (I tested it this time).
I've also noticed that this action still uses actions/upload-action@v3 (uses deprecated node version), so I updated it to v4.
While testing, I noticed that the action fails even though it succeeded, because since https://github.com/ZedThree/clang-tidy-review/pull/103, the action exits with the amount of comments. I'd like to open a PR (after this one) that adds an option to disable this.
I'm sorry for not testing properly in https://github.com/ZedThree/clang-tidy-review/pull/115. The stuff still fails, because pygithub doesn't follow redirects and the artifact is a binary blob, not JSON (I tested it this time).
https://github.com/ZedThree/clang-tidy-review/pull/113 noted that using
requestsisn't nice, so I'm usingurllib3. Theacceptheader might look weird, but the documentation recommends this even though we get a zip returned 🙃.I've also noticed that this action still uses
actions/upload-action@v3(uses deprecated node version), so I updated it to v4.While testing, I noticed that the action fails even though it succeeded, because since https://github.com/ZedThree/clang-tidy-review/pull/103, the action exits with the amount of comments. I'd like to open a PR (after this one) that adds an option to disable this.