ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

chore: add `num_comments_as_exitcode` option #119

Closed Nerixyz closed 6 months ago

Nerixyz commented 6 months ago

I mentioned this in #118 a bit. Having the exit-code be non-zero will cause the workflow to count as failed, even though it posted the comments successfully, which will notify the user. Using continue-on-error isn't ideal for this either, as it will hide errors in this action. On the other hand, I can understand the use-case for this.

I'm adding the num_comments_as_exitcode input/option, which, as the name suggests, controls whether the exit-code will be set to the number of comments or 0. It's enabled by default, so nothing should change.