ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

Review deduplication doesn't work in some cases when combining Windows and Linux #129

Closed bwrsandman closed 2 months ago

bwrsandman commented 4 months ago

Some messages ask to change variable names and will have different positions where these changes must happen e.g.

src/main.cpp:42

-foo = 0;
+bar=0;

The issue is that if the review step was run on windows runner, the message will use forward slashes

src\main.cpp:42

-foo = 0;
+bar=0;

This results in an inability to de-duplicate the message since src/main.cpp:42 is different from src\main.cpp:42

I think a solution would be to convert all \\ characters to / for the comparison tests and make sure that works also for already posted messages.