ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Fix remaining Ruff lints and (most) type errors #137

Closed Nerixyz closed 2 weeks ago

Nerixyz commented 3 weeks ago

As the title says, this fixes the remaining lints from https://github.com/ZedThree/clang-tidy-review/pull/133 (that's the target of the PR) as well as some typing errors (the remaining ones can be fixed in a separate PR). I noticed that pygithub now has PullRequest.get_comments which we could migrate to. Furthermore, there should probably a ruff check in CI.

Aside: A release would be great. Currently, comments are duplicated (not culled) - this is fixed on master (I think).