search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Running commands inside the docker #22

Closed umutoztunc closed 2 years ago

umutoztunc commented 2 years ago

It would be nice if we could pass some commands to docker instance apart from apt packages.

Currently, we don't keep a compilation database in our repository. We generate it during github workflows via cmake. Is there a way to make it work with this action so that we can install cmake and generate the compilation database there?

ZedThree commented 2 years ago

The way I do it is to have a step in the workflow that creates the compilation database first, but given that you often need to install packages in both the parent workflow and then also inside the docker container, it probably makes more sense to also pass in the CMake arguments.

umutoztunc commented 2 years ago

Thanks, I confirm that it works when we create the compilation database first. I am not sure whether you'd like to keep this issue open or not. Thus, I will leave it up to you.