search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

0.8.0 doesn't work #27

Closed vadi2 closed 2 years ago

vadi2 commented 2 years ago

Really excited to try the new fixits feature, but having some difficulty with the new version of the action: build log & PR

ZedThree commented 2 years ago

Thanks for the bug report! It looks like --export-fixes doesn't create a file if there are no suggestions. When testing, it seems I hadn't considered the case when there's nothing to report.

Should be a pretty easy fix

ZedThree commented 2 years ago

@vadi2 Does #28 work for you?

I really need to work out how to get CI working for this!

vadi2 commented 2 years ago

The action worked well - https://github.com/Mudlet/Mudlet/runs/5124404130?check_suite_focus=true

clang-tidy isn't picking up a couple of fixits that it should be - digging into that, but that is a separate problem. Thanks for the quick fix!

ZedThree commented 2 years ago

Thanks! 0.8.1 now released