search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Docker build fails #36

Closed vadi2 closed 2 years ago

vadi2 commented 2 years ago

See https://github.com/Mudlet/Mudlet/runs/6125396129?check_suite_focus=true - the docker build has started to fail for some reason.

ZedThree commented 2 years ago

Oops, we're using ubuntu:latest which is now 22.04 and has different clang-tidy packages: https://packages.ubuntu.com/search?keywords=clang-tidy&searchon=names&suite=jammy&section=all

Trivial fix, although it would change the versions of clang-tidy

jellespijker commented 2 years ago

This still fails, even when specifying ubuntu-20.04 https://github.com/Ultimaker/CuraEngine/pull/1652

ZedThree commented 2 years ago

clang-tidy-review uses its own docker container, which is unrelated to the parent Action's container: https://github.com/Ultimaker/CuraEngine/runs/6175255484?check_suite_focus=true#step:2:5

I'll pin to ubuntu-20.04 for now.

jellespijker commented 2 years ago

thank you for the quick response and fix