search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

Removed raise in case of clang-tidy error #40

Closed FlorianReimold closed 2 years ago

FlorianReimold commented 2 years ago

I removed the raise mentioned in #39

The amazing thing is: Now the action out of the box displays clang-diagnostic-* warnings! I am surprised, but it's just as it should be now 🥳

here you can see a test PR with my fork that caused a compile error that was however properly posted by clang-tidy-review afterwards: https://github.com/FlorianReimold/ecal/pull/12

I have not tested for side-effects. Not sure if that raise had any important role

ZedThree commented 2 years ago

Neat! Thanks @FlorianReimold!