search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
88 stars 44 forks source link

Feedback posted as comments instead of annotations #77

Closed vadi2 closed 1 year ago

vadi2 commented 1 year ago

I enabled annotations in my config, but all the feedback still got posted as comments. What could be going wrong?

ZedThree commented 1 year ago

Oh, if you're using split_workflow, that needs to be on the post action, rather than review. Sorry, that's not very clear in the docs

vadi2 commented 1 year ago

Aha, thanks. What about lgtm_comment_body?

ZedThree commented 1 year ago

Good point, that too, plus max_comments all need to be in whichever workflow is posting the review.