search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Add option to let clang-tidy find the config file on its own #80

Closed psalz closed 1 year ago

psalz commented 1 year ago

By default clang-tidy will attempt to find the .clang-tidy file that is closest to the source file it is currently checking. This is useful if one wants to have different sets of checks for different folders. By setting --config-file explicitly this behavior is overriden, and all files are checked with the same config. It would be great if there was an option to disable the Python wrapper from passing the option at all!

ZedThree commented 1 year ago

Ah, I didn't realise that was possible! Ok, we need to a bit more clever about setting that option then

ZedThree commented 1 year ago

PR in #96 that fixes this