search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Option to set `--extra-arg` #89

Open bwrsandman opened 1 year ago

bwrsandman commented 1 year ago

I'm running into an issue where I'm getting an irrelevant warning on my source code that happens when a define is not set. This is a check to prevent inclusion of certain headers without the define.

When compiling, the correct cpp files have the define but clang-tidy will not have them when analyzing the header itself.

The solution to this is adding --extra-arg=-DMY_DEFINE to the command line. In clang-tidy 17, you can set this in the config with ExtraArgs but I'm currently on 15.

Either way, I don't see such an option in clang-tidy-review

Note that multiple --extra-arg can be set one after the other.

BotellaA commented 1 year ago

This option would be very useful!

ZedThree commented 1 year ago

Sounds good. Not sure I'll have much time to implement this myself for awhile, but PRs always welcome!