search

ZedThree / clang-tidy-review

Create a pull request review based on clang-tidy warnings
MIT License
90 stars 45 forks source link

Option to not use line filters #99

Closed bwrsandman closed 10 months ago

bwrsandman commented 1 year ago

I'm looking for a way to create an action that only triggers if a .clang-tidy file has been changed. This would presumably have an empty line filter. However, practically this would require running clang tidy on the whole project since that project could be non compliant. Is there a way to not issue a line filter?

ZedThree commented 1 year ago

I think in that case, it's probably best to run clang-tidy manually

bwrsandman commented 1 year ago

What about running nightlies that check the whole project? Sometimes having line filters results in old code having old rules. Seems like this action is well positioned to avoid doing this manually?

ZedThree commented 1 year ago

Hmm, that would be useful, yeah. I guess you could turn off posting comments and just have it upload the review as an artefact so that it works on plain commits and not just PRs.

bwrsandman commented 10 months ago

Closing because it's easy to just make a workflow that calls clang tody