search

Zedenem / UICircularSlider

an iOS UISlider which displays value in a circle / pie.
143 stars 52 forks source link

UIControlEventTouchUpInside not being called #6

Closed s1ris closed 10 years ago

s1ris commented 10 years ago

This is a great control, being much more smooth and stable than other circular sliders. However, UICircularSlider does not seem to respond to UIControlEventTouchUpInside, making it difficult to determine when the user has finished touching the control. It would be great if your control supported said UIControlEvent, and very helpful as well.

Zedenem commented 10 years ago

Hi!

Just pulled this: https://github.com/Zedenem/UICircularSlider/pull/7

Could you have a look at it and tell me if it's what you need?

Basically, I tried to go one step further (® Nostalgia Critic) by also handling the TouchDown and distinguishing TouchUpInside from TouchUpOutside.

All this is, unlike iOS default UISlider, triggered to the thumb image and not the entire UICircularSlider view frame

s1ris commented 10 years ago

Thank you, it works perfectly!