search

ZeeCoder / use-resize-observer

A React hook that allows you to use a ResizeObserver to measure an element's size.
MIT License
644 stars 42 forks source link

Feat: Allow to define the default width/height #8

Closed SBoudrias closed 5 years ago

SBoudrias commented 5 years ago

For use within SSR context, it's quite useful to be able to define a default size.

Let me know if this change makes sense for you.

ZeeCoder commented 5 years ago

Yeah, makes sense. 👍 Can you add it to the changelog and package.json as 3.2.0?

ZeeCoder commented 5 years ago

Actually, one more thing: could you try adding a test for it? If not I can do it as well, but as I'm preparing for my wedding I'm unlikely to have time until mid-June for sure.

SBoudrias commented 5 years ago

Hey, I was going to add a test initially, but the current test structure is hard to extend. So I didn't do it.

ZeeCoder commented 5 years ago

Yeah I'll have to do it after the my wedding, about a month from now. Just nudge me then again.

On Tue, 21 May 2019 at 03:43, Simon Boudrias notifications@github.com wrote:

Hey, I was going to add a test initially, but the current test structure is hard to extend. So I didn't do it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ZeeCoder/use-resize-observer/pull/8?email_source=notifications&email_token=AA4CKEVR57S2M3DL43FRNHDPWNHSPA5CNFSM4HN6EBH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2QGWQ#issuecomment-494207834, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4CKEUZCGBYHEJJAUVZRVLPWNHSPANCNFSM4HN6EBHQ .

SBoudrias commented 5 years ago

I've updated the CHANGELOG and updated the version.

Hopefully we can move forward without the tests as it's not really bringing a lot of values in this specific case.

ZeeCoder commented 5 years ago

I've moved things to #10 , which includes tests as well. @SBoudrias can you check if the changes make sense to you?

Also, could you advise on how to update the TS types?

ZeeCoder commented 5 years ago

I think I'll just remove types and do a major release.