search

Zeepheru / pe

0 stars 0 forks source link

Invalid Singapore Postal Codes are Allowed #2

Open Zeepheru opened 1 week ago

Zeepheru commented 1 week ago

Description

The first two digits of valid Singapore postal codes are defined based on the postal district of an address, and range from 01 to 80.

That means that postal codes such as 000000 or 999999 should not be valid, but they can be input into ClientGrid:

image.png

image.png

nus-se-script commented 1 week ago

Team's Response

Thank you for your feedback! ClientGrid is a continual work in progress with many ways to continuously improve. At this juncture, we view your proposal as overzelous checks on postal sectors (first two digits of postal code) which is more likely to become a possible hindrance to property agents rather than a benefit. We have noted that your input is handled by the app gracefully by accepting the input. We clarify the rationale as follows:

  1. Adaptability for Future Postal Sectors: Singapore’s postal sectors are arbitrarily assigned based on general property locations. These sectors are not fixed and may expand as new estates and developments arise. If the app were to aggressively restrict input to only current valid sectors, it could result in significant inconvenience for property agents in the future. Property agents working in newly developed areas might find valid postal codes rejected by the app, causing unnecessary delays till the developer team releases new patches to accept the postal sectors of new estates. Given that such agents will need to input their new postal codes immediately to serve clients effectively, such restrictions could hinder their operations.

  2. Adherence to Official Guidelines: Our approach aligns with the official guidelines (See Section 1.7), which only mandates postal codes to have six digits. There are no mandates for sector-based validation beyond this format. Therefore, the current implementation offers the most reasonable, non-restrictive and future-proof approach, ensuring usability without overcomplicating the validation process.

That said, we recognize the importance of ensuring postal codes are as accurate as possible to serve users effectively. As part of future iterations, we propose conducting additional surveys with property agents to determine whether stricter checks for valid postal sectors would enhance usability. For now, we believe the current implementation is sufficient to meet the needs of property agents, balancing flexibility, practical functionality and future-proof.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]