search

Zeex / samp-plugin-crashdetect

Crash/error reporting plugin for SA-MP server
http://forum.sa-mp.com/showthread.php?t=262796
BSD 2-Clause "Simplified" License
116 stars 23 forks source link

Quick question #91

Closed Cheaterman closed 3 years ago

Cheaterman commented 3 years ago

Is it possible/normal that filterscripts would segfault crashdetect if compiled with -d2 instead of -d3? This used to be fine, but I changed compilers since then (I now use the modern one, that's picky about consts and whatnot). Thanks in advance!

EDIT: Side question... If things complain about TEXTREL and -fPIC isn't good for SAMP stuff (is it?) should I use -nopie?

Cheaterman commented 3 years ago

I recompiled everything (as much as possible) with -fPIC and I can at least load crashdetect.so without immediately crashing, so I'm closing this. :-)

Zeex commented 3 years ago

Hmm, isn't it compiled by default with -fPIC with CMake? or you are not using CMake?

Cheaterman commented 3 years ago

@Zeex I suspect crashdetect wasn't the immediate issue, I since then recompiled some plugins with -fsanitize=address, used some valgrind etc, found quite a few really broken things to fix - I'm probably not done yet, I still hope crashdetect will point to more issues if I still have any, or I'll just swap plugins that are obviously faulty (after code review) for ones with cleaner code, hahaha. But if everything works here and is stable, that's good enough to me - either way, really not crashdetect's fault, despite the initial symptoms - possibly some non-PIC plugins trashing memory or stack :-)