search

Zeex / samp-plugin-profiler

Performance profiler plugin for SA-MP server
http://forum.sa-mp.com/showthread.php?t=271129
BSD 2-Clause "Simplified" License
46 stars 8 forks source link

Rename profiler.inc to samp_profiler.inc (#33) #39

Closed Fairuz-Afdhal closed 2 years ago

Fairuz-Afdhal commented 2 years ago

@Zeex why? The issue is still exists especially for sampctl users, they have to delete/rename profiler.inc to something else and I feel like this is the appropriate name for the include.

Zeex commented 2 years ago

IMO it's something that should be addressed by sampctl

ADRFranklin commented 2 years ago

This is not a sampctl issue, the same issue would happen without sampctl, remember sampctl is just calling the pawncc with include paths, however because of the behaviour of pawncc when 2 files with the same name can be included from the include path directly, sampctl will throw an error about this problem, just to make the user aware, since there is no way to tell which include the pawncc will choose to use when you include it.

There isn't really a good solution for this, other then renaming the files. I'm open to suggestions that sampctl could do to help mitigate this issue, but once again this shouldn't be a sampctl problem.

ADRFranklin commented 2 years ago

We have already had this conversation here a while back: https://github.com/Zeex/samp-plugin-profiler/issues/33