[Bug]: AST raidbuff triggering TTS twice and BRD raidbuff TTS not triggering

mnpqraven commented 3 years ago

What are you trying to do?

Enabling TTS for raidbuffs

What is the expected behaviour?

Raidbuff bar displaying and triggers TTS when used

What actually happened?

Divination's TTS being triggered twice, other raid buffs other than battle voice triggering TTS as expected, battle voice doesn't trigger TTS

Logs

[8/25/2021 12:34:58 AM] Info: ZeffUI: BrowserConsole: ZeffUI fully loaded. (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 103)
[8/25/2021 12:35:13 AM] Info: Preview: BrowserConsole: ZeffUI fully loaded. (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 103)
[8/25/2021 12:35:20 AM] Info: zeffui: BrowserConsole: ZeffUI fully loaded. (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 103)
[8/25/2021 12:35:36 AM] Info: zeffui: BrowserConsole: ZeffUI fully loaded. (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 103)
[8/25/2021 12:35:41 AM] Info: zeffui: BrowserConsole: Uncaught TypeError: Cannot read property 'style' of null (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 1999)
[8/25/2021 12:36:02 AM] Info: zeffui: BrowserConsole: Uncaught TypeError: Cannot read property 'style' of null (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 1999)
[8/25/2021 12:38:04 AM] Info: zeffui: BrowserConsole: Uncaught TypeError: Cannot read property 'style' of null (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 1999)
[8/25/2021 12:38:47 AM] Info: zeffui: BrowserConsole: Uncaught TypeError: Cannot read property 'style' of null (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 1999)
[8/25/2021 12:39:03 AM] Info: zeffui: BrowserConsole: Uncaught TypeError: Cannot read property 'style' of null (Source: https://zeffuro.github.io/ZeffUI/scripts/index.js, Line: 1999)

FFXIV Update

[X] I have confirmed that I have the latest version of Ravahn's FFXIV_ACT_Plugin, ngld's OverlayPlugin and cactbot (for the memory reading) are up to date.

Zeffuro commented 3 years ago

Still working on find out why Divination triggers twice. When you tested Battle Voice, were you the BRD in question? Because I manually disable TTS on BRD if you're the Battle Voice user because it doesn't affect the BRD who used it:

ffxiv_dx11_2021-08-25_03-10-31

Could you also export your profile? (and either upload it to something like pastebin or a github gist)?

mnpqraven commented 3 years ago

sorry for the late reply, you're correct i was the one as BRD, totally forgot that it doesn't give you the buff itself. As for my profile here it is https://pastebin.com/XbgmyHe7

CSIXIV commented 3 years ago

The following raid buffs seems to trigger the TTS twice, while it being activated through the raid buff tab the override thing as well :

Brotherhood
Litany
Divination
Battle Voice (not for the Bard itself)

I suspect it activate twice because of the buff application : a 1st time when the button is pressed, a second time when the buff is applied. That would explain why raid buff like trick attack and chain stratagem (who are debuffs on the boss and not a buff applied to the party) work as intended. That's just a supposition though.

Zeffuro commented 3 years ago

Yeah I do believe that to be the case. For me to test this I need to get lucky in roulettes activating it or get someone who can press the button for me. I can straight up ignore those buffs in 1 of the 2 but rather not hardcode it but make it sort of optional since buff application vs skill pressed was a backup method basically.

CSIXIV commented 3 years ago

Well if you need help testing in game feel free to dm me on discord, we spent an hour with friends testing it yesterday i'll be happy to help the dev. I only have concerned jobs leveled on Chaos, EU though. Cyane#8888

Zeffuro commented 2 years ago

Sorry for the long wait, I implemented an option that should prevent this but it needs a bit of testing.

Zeffuro / ZeffUI