Zehina / Webtoon-Downloader

Webtoons Scraper able to download all chapters of any series wanted.
https://zehina.github.io/Webtoon-Downloader/
MIT License
138 stars 35 forks source link

Something, probably the latest release, has broken all WEBTOON downloading. #4

Closed Corrupt-Specturion closed 2 years ago

Corrupt-Specturion commented 2 years ago

Traceback (most recent call last): File "webtoon_downloader.py", line 169, in <module> def get_chapters_details(session: requests.session, viewer_url: str, start_chapter: int = 1, end_chapter: int = None) -> list[ChapterInfo]: TypeError: 'type' object is not subscriptable Traceback (most recent call last): File "webtoon_downloader.py", line 169, in <module> def get_chapters_details(session: requests.session, viewer_url: str, start_chapter: int = 1, end_chapter: int = None) -> list[ChapterInfo]: TypeError: 'type' object is not subscriptable

I've made sure the requirements are properly satisfied.

Zehina commented 2 years ago

Are you using an older version of Python (i.e Python ≤ 3.6.x) ? The project was never meant to support Python 3.6.x, though yes the issue can be fixed by removing type hinting of the return function. Not all other functionalities are being tested on this specific version.

Corrupt-Specturion commented 2 years ago

image

Corrupt-Specturion commented 2 years ago

It worked fine before the latest release. I'm thinking one of the commits after you fixed the challenge downloading messed it up.

Zehina commented 2 years ago

@Corrupt-Specturion Thank you, I've manager to fix it in 6c9d95933642672d3f3845d06bcfdb4a3b553933. It Should not break now, let me know if all your cases work as intended know using the latest release.

Corrupt-Specturion commented 2 years ago

It works fine now, thanks.