search

Zehina / Webtoon-Downloader

Webtoons Scraper able to download all chapters of any series wanted.
https://zehina.github.io/Webtoon-Downloader/
MIT License
138 stars 35 forks source link

Incorrect File Extenstions #8

Closed johninaba closed 9 months ago

johninaba commented 2 years ago

Occasionally the downloaded images have the incorrect extension . PNG instead of JPEG for example.

Zehina commented 2 years ago

Could you provide the options you provided when running the script ?

johninaba commented 2 years ago

-d was the only option I used.

Zehina commented 2 years ago

What's the entire command you used. Webtoon url and options.

johninaba commented 2 years ago

python webtoon_downloader.py -d d:\test https://www.webtoons.com/en/romance/lore-olympus/list?title_no=1320

Zehina commented 2 years ago

This is due, to the project assuming that all images are JPEG by default, since that's what they normally use. But I guess this should be changed to actually convert images that are downloaded as PNG to JPEG.

johninaba commented 2 years ago

Maybe add file type detection as well with an option to keep the original format. I've just been renaming with IrfanView in the interim.

Zehina commented 9 months ago

This is now fixed in 1.0.0. Images should be properly converted depending on the provided image extension