search

ZeitOnline / celery_longterm_scheduler

Schedules celery tasks to run in the potentially far future
BSD 3-Clause "New" or "Revised" License
27 stars 8 forks source link

Support for celery 5.x.x #6

Closed aakash2610 closed 2 years ago

aakash2610 commented 3 years ago

I tried to use this repo with Celery v5.0.2. This code does not work. It is giving me error: AttributeError: module 'celery.bin.base' has no attribute 'Command'

I looked at the celery and found out that Command class has been removed since v5.0.0. Can you please fix the code to support the latest celery version?

Thanks,

jeffreybrowning commented 3 years ago

Any movement on this?

jeffreybrowning commented 3 years ago

@zon-hoppe @wosc Sorry for the summons. Can we get pointed in the right direction for how to fix this, or is it simple for one of you to hop on?

wosc commented 3 years ago

Hi there. We do have "update celery from 4.x to 5.x throughout our projects" in our backlog, but there's no date yet when we will be able to get to it.

From reading the celery docs (one, two), the main bw-incompatible change in 5.x seems to be that they've replaced their custom CLI mechanics with click. Thus, our Command setup here needs to be adjusted to that new API. I'm hoping that should be rather straightforward, but as I said, not sure when we'll have the capacity. So if one of you wants to tackle this, I'd be more than happy to merge a patch.

jeffreybrowning commented 3 years ago

@wosc Thanks for the direction!

wosc commented 2 years ago

Fixed in dcea99b and released as 1.2.0