search

ZekerZhayard / ForgeWrapper

Allow MultiMC to launch Minecraft 1.13+ with Forge
MIT License
53 stars 17 forks source link

Java properties not working? #2

Closed eDexiam closed 4 years ago

eDexiam commented 4 years ago

Hi there, I can't get Java property to work, I'm not exactly sure why but here is the error I am getting. image

I am using the Java properties according to the readme.

ZekerZhayard commented 4 years ago

Java properties are used in Minecraft Launcher, not in ForgeWrapper converter.

eDexiam commented 4 years ago

So, how can I set it up then?

ZekerZhayard commented 4 years ago

Which launcher are you using?

eDexiam commented 4 years ago

I'm using this launcher https://github.com/dscalzi/HeliosLauncher

ZekerZhayard commented 4 years ago

I still can’t understand how this launcher works after taking a few hours. can you tell me some more information?

eDexiam commented 4 years ago

Sure, the launcher works on a modpack basis, the modpack is downloaded from a server, the problem with it is that it downloads the forge jar client for that server as well which is not allowed because of minecraft's EULA, so I would like to try to use your wrapper to install forge automatically on clients

jamierocks commented 4 years ago

Just to interject a bit here - the error message does say how you should be invoking ForgeWrapper.

ZekerZhayard commented 4 years ago

oh, ForgeWrapper couldn't do this. the role of ForgeWrapper is to install Forge 1.13+ after clicking "launch game" button in the launcher and before the game actually being launched.

eDexiam commented 4 years ago

That's what I'm trying to implement using forge wrapper

Pyker commented 4 years ago

I think you should be adding ForgeWrapper in the classpath, and then call the actual right class (and not the entrypoint of the JAR, which is the outdated/unused Converter class), but I might be wrong about this.